Added hotkey start & select exit #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a start & select hotkey that stops the main loop and closes the game. The start & select exit is the standard function for users on RetroPie, Lakka and Batocera. It also allows the game to be played and closed without a keyboard.
|
Shouldn't this be off by default? A user might accidentally close the game |
|
I guess it's possible. But it's the standard exiting functionality of a lot of SBC emulation type machines (Start & Select) and Retroarch. Can't think of many games that require you to mash start and select together offhand. |
|
I want to run the game on a device that has no other means of exiting the game. So, I re-worked your idea into my fork I also added a settting to the config ini to enable/disable it. As @UltraHDR suggested, the default is off. Your case, @retropieuser, would be achieved via: # Allows to quit the game by pressing start and select buttons together
GamepadQuit = 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a start & select hotkey that stops the main loop and closes the game. The start & select exit is the standard function for users on RetroPie, Lakka and Batocera. It also allows the game to be played and closed without a keyboard.
Description
Will this Pull Request break anything?
Suggested Testing Steps