refactor: replace repeated patches of snowflake.connector.connect… #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,11 +31,10 @@ | |||
| @mock.patch("snowflake.cli._app.telemetry.platform.platform") | |||
| @mock.patch("uuid.uuid4") | |||
| @mock.patch("snowflake.cli._app.telemetry.get_time_millis") | |||
| @mock.patch("snowflake.connector.connect") | |||
There was a problem hiding this comment.
- patches need to be provided in test function arguments in reverse order, which is a bit less convenient than just passing a fixture name
- With a single fixture, it's easier to account for any changes to name/location of
connector.connect
sfc-gh-jwilkowski
force-pushed
the
jw/mock-connect
branch
from
fe5ea13 to
0565832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… with a fixture
Pre-review checklist
Changes description
proposal for a minor refactor of 1 fixture