Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove 38 reqs file #2146

Merged
merged 1 commit into from
Jan 24, 2025
Merged

remove 38 reqs file #2146

merged 1 commit into from
Jan 24, 2025

Conversation

sfc-gh-mkeller
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Removing this now unused file needs to be removed for the release.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-mkeller sfc-gh-mkeller added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Jan 24, 2025
@sfc-gh-mkeller sfc-gh-mkeller merged commit 94e9943 into main Jan 24, 2025
36 of 50 checks passed
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/remove-old-requirements-file branch January 24, 2025 01:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mmishchenko sfc-gh-mmishchenko sfc-gh-mmishchenko approved these changes

Assignees
No one assigned
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mkeller @sfc-gh-mmishchenko