Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-957747: Easy logging improvements #1730

Merged

Conversation

sfc-gh-ext-simba-nl
Copy link
Collaborator

@sfc-gh-ext-simba-nl sfc-gh-ext-simba-nl commented Apr 23, 2024

Overview

SNOW-957747

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes 731

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Improve easy logging based on notes mentioned in 731

@sfc-gh-ext-simba-nl sfc-gh-ext-simba-nl requested a review from a team as a code owner April 23, 2024 00:12
@sfc-gh-pbulawa
Copy link
Collaborator

I have been working on the Logging improvements in JDBC #1662. The logs for the Easy logging have been added there, along with some custom classes.

I am wondering if it would be feasible to rebase this PR onto #1662 and add only missing bits @sfc-gh-dprzybysz what do you think?

@sfc-gh-dprzybysz sfc-gh-dprzybysz changed the title Easy logging improvements SNOW-957747: Easy logging improvements Apr 30, 2024
Copy link
Contributor

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit f39eff4 into master Jul 2, 2024
141 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-957747-easy-logging-configuration-improvement branch July 2, 2024 07:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants