-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-957747: Easy logging improvements #1730
SNOW-957747: Easy logging improvements #1730
Conversation
src/main/java/net/snowflake/client/config/SFClientConfigParser.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/config/SFClientConfigParser.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/config/SFClientConfigParser.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/DefaultSFConnectionHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/DefaultSFConnectionHandler.java
Outdated
Show resolved
Hide resolved
I have been working on the Logging improvements in JDBC #1662. The logs for the Easy logging have been added there, along with some custom classes. I am wondering if it would be feasible to rebase this PR onto #1662 and add only missing bits @sfc-gh-dprzybysz what do you think? |
src/test/java/net/snowflake/client/config/SFPermissionsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/config/SFPermissionsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/config/SFPermissionsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/config/SFPermissionsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/log/JDK14LoggerWithClientLatestIT.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/log/JDK14LoggerWithClientLatestIT.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/log/JDK14LoggerWithClientLatestIT.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/log/JDK14LoggerWithClientLatestIT.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/log/JDK14LoggerWithClientLatestIT.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/DefaultSFConnectionHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/DefaultSFConnectionHandler.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/config/SFPermissionsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/config/SFPermissionsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/config/SFPermissionsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/log/JDK14LoggerWithClientLatestIT.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/log/JDK14LoggerWithClientLatestIT.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/log/JDK14LoggerWithClientLatestIT.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/log/JDK14LoggerWithClientLatestIT.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/config/SFClientConfigParser.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/DefaultSFConnectionHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/DefaultSFConnectionHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/config/SFClientConfigParser.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/config/SFClientConfigParser.java
Outdated
Show resolved
Hide resolved
…est case to only run on posix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview
SNOW-957747
Pre-review self checklist
master
branchmvn -P check-style validate
)mvn verify
and inspecttarget/japicmp/japicmp.html
)SNOW-XXXX:
External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes 731
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi
(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Improve easy logging based on notes mentioned in 731