Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1846830 allow triple slash file prefix (file:///) #2033

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

sfc-gh-mkubik
Copy link
Contributor

@sfc-gh-mkubik sfc-gh-mkubik commented Jan 15, 2025

Apparently triple slash prefix doesn't work on windows as it driver resolves it to something like /C:/path/to/file and such path doesn't exist. The primary reason for this is that driver simply cuts file:// prefix from the string provided by user and the result of this operation is directly passed to the upload function. The quick fix is using the java.io.File parsed path.

Without the fix from PR#2035 the upload with file:/// doesn't throw an error but as the test result shows - no file is being uploaded.

Overview

SNOW-1863648

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

@sfc-gh-mkubik sfc-gh-mkubik changed the title use path from java.io.File instead of raw user provided string to ena… SNOW-1846830 allow triple slash file prefix (file:///) Jan 15, 2025
@sfc-gh-mkubik sfc-gh-mkubik marked this pull request as ready for review January 31, 2025 14:17
@sfc-gh-mkubik sfc-gh-mkubik requested a review from a team as a code owner January 31, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants