-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1877449:Exception should be thrown when create df with null value and nullable set to False #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jrose
approved these changes
Jan 14, 2025
Comment on lines
168
to
171
for i in range(rows_to_compare): | ||
for j in range(len(self.output)): | ||
if self.data[i][j] is None and not self.output[j].nullable: | ||
return True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially a lot fewer comparisons if you restructured like this.
Suggested change
for i in range(rows_to_compare): | |
for j in range(len(self.output)): | |
if self.data[i][j] is None and not self.output[j].nullable: | |
return True | |
for j in range(len(self.output)): | |
if not self.output[j].nullable: | |
for i in range(rows_to_compare): | |
if self.data[i][j] is None: | |
return True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, will change
sfc-gh-aalam
approved these changes
Jan 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lable column
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1877449
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This bug caused by ARRAY_BIND_THRESHOLD parameter in snowpark, we use it to decide whether we insert the data into temporary table when creating a dataframe. Currently the threshold is 512. So if row number * colum number <512, no insert query is executed, which means no error will be thrown when NULL value is in non-nullable column. This mean we had a false behavior before and some of the test needs to be fixed
when create a dataframe where number of columns * number of rows < 512, instead of inserting data into snowflake table, such query is executed:
SELECT "KEY" FROM ( SELECT $1 AS "KEY" FROM VALUES (NULL :: INT)) LIMIT 10
this query would ignore all nullable settings on all columns, making snowpark have different behaviors when creating small and big dataframes.
This query cannot be modified so that it have the same behvior of inserting null value into a non-nullable table. So I add some assertions in our code to throw the same error, giving user consistent experiences.