Add support for IO#timeout in io_read, io_write and io_wait.
#296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
io-timeout-support
branch
from
e8a81b0 to
e3555e0
Compare
3 tasks
ioquatix
force-pushed
the
io-timeout-support
branch
from
54c4de1 to
be8bd28
Compare
ioquatix
changed the title
io_read, io_write and io_wait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IO#timeoutwas introduced recently and is a safety mechanism for dealing with blocking IO operations. We need to correctly handle it in the scheduler.We also probably need to implement an upstream fix as it's not clear that
wait_readable/wait_writableshould raise an exception as the current implementation does.Types of Changes
Contribution