make Huffman
methods class methods to avoid unnecessary allocations
#9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol::HPACK::Huffman
doesn't maintain any state, so there's no reason forencode
/decode
to be instance methods. Making them class methods means we can avoid allocating instances during header encoding/decoding, which improves performance (~2% on my machine, but the benchmark is a bit noisy).Types of Changes
Contribution