fix: fixed array serialization and typo in descriptor

software-mansion-labs · Sep 2, 2024 · 421908b · 421908b
1 parent 2a64c01
commit 421908b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/android/src/main/cpp/AudioBuffer/AudioBuffer.h b/android/src/main/cpp/AudioBuffer/AudioBuffer.h
@@ -12,7 +12,7 @@ namespace audiocontext {
 
     class AudioBuffer : public jni::HybridClass<AudioBuffer> {
     public:
-        static auto constexpr kJavaDescriptor = "Lcom/audiocontext/parameters/AudioBuffer;";
+        static auto constexpr kJavaDescriptor = "Lcom/audiocontext/utils/AudioBuffer;";
 
         static jni::local_ref<AudioBuffer::jhybriddata> initHybrid(jni::alias_ref<jhybridobject> jThis)
         {

diff --git a/cpp/AudioBuffer/AudioBufferHostObject.cpp b/cpp/AudioBuffer/AudioBufferHostObject.cpp
@@ -37,7 +37,13 @@ namespace audiocontext {
             return jsi::Function::createFromHostFunction(runtime, propNameId, 1, [this](jsi::Runtime& rt, const jsi::Value& thisVal, const jsi::Value* args, size_t count) -> jsi::Value {
                 int channel = args[0].getNumber();
                 short** channelData = wrapper_->getChannelData(channel);
-                return jsi::Value::null();
+
+                auto array = jsi::Array(rt, wrapper_->getLength());
+                for (int i = 0; i < wrapper_->getLength(); i++) {
+                    array.setValueAtIndex(rt, i, jsi::Value(channelData[i]));
+                }
+
+                return array;
             });
         }