Feat/audio buffer #105
Merged
Feat/audio buffer #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 27, 2024 13:10
added 15 commits
August 30, 2024 13:28
This reverts commit 8d7500a.
michalsek
approved these changes
Sep 2, 2024
| val pan = pan.getValueAtTime(context.getCurrentTime()) | ||
| val x = (pan + 1) / 2; | ||
| val x = (pan + 1) / 2 |
There was a problem hiding this comment.
Suggested change
| val x = (pan + 1) / 2 | |
| val x = (if (pan <= 0) pan + 1 else pan) * PI / 2 |
Comment on lines
34
to
35
| playbackParameters.leftPan *= gainL | ||
| playbackParameters.rightPan *= gainR |
There was a problem hiding this comment.
Suggested change
| playbackParameters.leftPan *= gainL | |
| playbackParameters.rightPan *= gainR | |
| // TODO: This assumes both channels play the same sound (buffer) | |
| // but it should mix the channels. F.e. pan < 0: leftChannel = leftChannel + leftGain * rightChannel | |
| if (pan <= 0) { | |
| playbackParameters.leftPan *= (1+gainL) | |
| playbackParameters.rightPan *= gainR | |
| } else { | |
| playbackParameters.leftPan *= gainL | |
| playbackParameters.rightPan *= (1+gainR) | |
| } |
There was a problem hiding this comment.
Can't find any better source that ppl arguing on online forums, but it seems that:
- doing a "gain change" on single channel aka
left = left * gainLis calledbalancing - doing a "gain change" when mixing the other(s?) channels is called panning
https://www.kvraudio.com/forum/viewtopic.php?t=148865
https://www.reddit.com/r/synthesizers/comments/14fqq4t/whats_the_difference_between_pan_and_balance/
|
|
||
| for (int frame = 0; frame < frameCount; frame++) { | ||
| double input = bufferL[frame]; | ||
| // double output = _b0 * input + _b1 * _x1 + _b2 * _x2 - _a1 * _y1 - _a2 * _y2; |
There was a problem hiding this comment.
Suggested change
| // double output = _b0 * input + _b1 * _x1 + _b2 * _x2 - _a1 * _y1 - _a2 * _y2; |
| float *bufferL = (float *)bufferList->mBuffers[0].mData; | ||
| float *bufferR = (float *)bufferList->mBuffers[1].mData; | ||
|
|
||
| for (int frame = 0; frame < frameCount; frame += 1) { | ||
| double pan = [_panParam getValueAtTime:[self.context getCurrentTime]]; | ||
| double x = (pan + 1) / 2; |
There was a problem hiding this comment.
Suggested change
| double x = (pan + 1) / 2; | |
| double x = ((pan <= 0) ? pan + 1 : pan) * M_PI / 2; |
Comment on lines
33
to
34
| bufferL[frame] *= cos(x * M_PI / 2); | ||
| bufferR[frame] *= sin(x * M_PI / 2); |
There was a problem hiding this comment.
Suggested change
| bufferL[frame] *= cos(x * M_PI / 2); | |
| bufferR[frame] *= sin(x * M_PI / 2); | |
| double gainL = cos(x); | |
| double gainR = sin(x); | |
| if (pan <= 0) { | |
| bufferL[frame] += bufferR[frame] * gainL; | |
| bufferR[frame] *= gainR; | |
| } else { | |
| bufferL[frame] *= gainL; | |
| bufferR[frame] += bufferL * gainR; | |
| } |
michalsek
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101
Closes #97
Closes #89