Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to not include macros in their coverage report #57

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Allow users to not include macros in their coverage report #57

merged 1 commit into from
Sep 13, 2024

Conversation

ksew1
Copy link
Member

@ksew1 ksew1 commented Sep 12, 2024 •
edited
Loading

Closes #56

@ksew1 ksew1 mentioned this pull request Sep 12, 2024
Merged
@ksew1 ksew1 linked an issue Sep 12, 2024 that may be closed by this pull request
Allow users to not include macros in their coverage report #56
Closed
@ksew1 ksew1 requested a review from THenry14 September 12, 2024 14:05
THenry14
THenry14 reviewed Sep 13, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
THenry14
THenry14 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@THenry14 THenry14 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, so you can treat the one comment I gave as nitpick

ddoktorski
ddoktorski requested changes Sep 13, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
crates/cairo-coverage/src/cli.rs Show resolved Hide resolved
crates/cairo-coverage/src/input/filter.rs Outdated Show resolved Hide resolved
crates/cairo-coverage/src/input/filter.rs Outdated Show resolved Hide resolved
crates/cairo-coverage/src/input/filter.rs Outdated Show resolved Hide resolved
@ksew1 ksew1 force-pushed the spr/main/dd9032f3 branch 4 times, most recently from 3890b72 to 33bdc91 Compare September 13, 2024 10:27
@ksew1 ksew1 requested a review from ddoktorski September 13, 2024 10:57
@ksew1 ksew1 merged commit d2cc5c6 into main Sep 13, 2024
10 checks passed
@ksew1 ksew1 deleted the spr/main/dd9032f3 branch September 13, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

@THenry14 THenry14 THenry14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to not include macros in their coverage report
3 participants
@ksew1 @THenry14 @ddoktorski