Forbid output update after EOS #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noituri
force-pushed
the
@noituri/fix-render-after-eos
branch
from
8d01d72 to
4802750
Compare
noituri
force-pushed
the
@noituri/fix-render-after-eos
branch
from
4802750 to
cfcada4
Compare
wkozyra95
approved these changes
Oct 21, 2024
noituri
force-pushed
the
@noituri/fix-render-after-eos
branch
from
c76bb6c to
fca2060
Compare
noituri
force-pushed
the
@noituri/fix-render-after-eos
branch
from
233a705 to
7493837
Compare
wkozyra95
reviewed
Oct 22, 2024
| @@ -123,7 +123,7 @@ pub fn offline_processing() -> Result<()> { | |||
| if !(1.9..=2.1).contains(&duration) { | |||
| return Err(anyhow!("Invalid duration: {}", duration)); | |||
| } | |||
| if !(930_000..=1_000_000).contains(&bit_rate) { | |||
| if !(930_000..=1_008_200).contains(&bit_rate) { | |||
There was a problem hiding this comment.
- if something changed in the compositor that affected this test then adjust lower bounds too.
- if you are doing something like this make sure to communicate it clearly. You added that change after getting PR approved and I only noticed this by accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #552