Publish arm docker images as part of the release process #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
reviewed
Dec 12, 2024
noituri
force-pushed
the
@noituri/build-arm-docker
branch
4 times, most recently
from
283dbd0 to
29db9de
Compare
wkozyra95
approved these changes
Jan 9, 2025
| - name: ⏩ Push ARM64 image | ||
| run: | | ||
| docker push ghcr.io/software-mansion/smelter:${{ github.sha }} | ||
| echo "ARM64_IMAGE_ID=$(docker inspect --format='{{index .RepoDigests 0}}' ghcr.io/software-mansion/smelter:${{ github.sha }})" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
Is this command show digest of a image that was build last? Seems hacky is there a way to avoid relaying on that build order?
There was a problem hiding this comment.
Discussed outside of GitHub
|
|
||
| docker push "${IMAGE_NAME}:${RELEASE_TAG}" | ||
| docker push "${IMAGE_NAME}:${RELEASE_TAG}-web-renderer" | ||
| docker buildx imagetools create -t "${IMAGE_NAME}:${RELEASE_TAG}" "${IMAGE_NAME}:${COMMIT_HASH}" |
There was a problem hiding this comment.
Is the docker pull above needed? I assumed that it only fetches image for one arch, so this command must not rely on what actual is fetched locally. (just guessing here)
There was a problem hiding this comment.
You're correct. The pull is not needed here. Fixed
noituri
force-pushed
the
@noituri/build-arm-docker
branch
2 times, most recently
from
e8c68a1 to
43896df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example multi-platform builds: