[ts-sdk] Ensure compositor instance cleanup (Node.js and browser) #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wkozyra95
commented
Jan 7, 2025
•
wkozyra95
commented
- Add LiveCompositor.terminate()
- Fix issues in rendering that caused LiveCompositor not to be garbage collected. (stored in global react state)
- Improve API of WASM package to make it simpler, plus add helpful component that wraps canvas
wkozyra95
changed the title
wkozyra95
force-pushed
the
@wkozyra95/ts-sdk-ensure-cleanup
branch
from
584ea57 to
7734ed6
Compare
wkozyra95
force-pushed
the
@wkozyra95/ts-sdk-ensure-cleanup
branch
from
7734ed6 to
8961617
Compare
wkozyra95
commented
Jan 7, 2025
| @@ -5,7 +5,7 @@ import init, * as wasm from './generated/compositor_web'; | |||
| * @param wasmModuleUrl {string} - An URL for `live-compositor.wasm` file. The file is located in `dist` folder. | |||
| */ | |||
| export async function loadWasmModule(wasmModuleUrl: string) { | |||
| await init(wasmModuleUrl); | |||
| await init({ module_or_path: wasmModuleUrl }); | |||
There was a problem hiding this comment.
passing string works, but it triggers warning
| public async close(): Promise<void> { | ||
| this.throttledUpdate.setFn(async () => {}); | ||
| this.renderer.stop(); | ||
| await this.throttledUpdate.waitForPendingCalls(); |
There was a problem hiding this comment.
I changed the throttledUpdate to class because I need to be able to wait for pending requests to finish, otherwise LiveCompositor.terminate() might kill the server before pending request are done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.