Add test rust command #2030
Closed
Add test rust command #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karol-bisztyga
requested review from
MaksymilianDemitraszek and
Arcticae
and removed request for
a team
piotmag769
approved these changes
May 31, 2023
|
Please not merge it right now wait until we clean up everything related to git |
piotmag769
reviewed
May 31, 2023
Comment on lines
+31
to
+37
| is_positional=True, | ||
| ), | ||
| ] | ||
|
|
||
| async def run(self, args: Namespace): | ||
| if args.path is None: | ||
| raise ProtostarException("No tests provided") |
There was a problem hiding this comment.
Suggested change
| is_positional=True, | |
| ), | |
| ] | |
| async def run(self, args: Namespace): | |
| if args.path is None: | |
| raise ProtostarException("No tests provided") | |
| is_positional=True, | |
| is_required=True, | |
| ), | |
| ] | |
| async def run(self, args: Namespace): |
piotmag769
reviewed
May 31, 2023
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "ignore": ["./starknet_in_rust/", "./blockifier/"] | |||
There was a problem hiding this comment.
Do we plan on using starknet in rust?
|
I think CLI is much closer to being merge than declare in rust right now. I don't think we should merge this one. Having additional bindings to python introduces additonal complexity and I prefer we avoided it. |
|
Is this PR needed anymore or can we close it? |
|
I'm going to close it once I come up with a replacement, I don't think it trashes the PR list that much and I use it as a ref so it's handy to have it as an open PR for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Cairo PR software-mansion-labs/cairo#78