Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user messaging when eas-cli is not installed #934

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

jwajgelt
Copy link
Contributor

@jwajgelt jwajgelt commented Feb 5, 2025

  • Improves build error messages when trying to use EAS Build without eas-cli installed.
  • Adds eas-cli installation status to the diagnostics window.

How Has This Been Tested:

Try to build an EAS Build project without eas-cli installed (eas executable should not be in PATH).
image

@jwajgelt jwajgelt requested a review from filip131311 February 5, 2025 14:37
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 3:01pm

@jwajgelt jwajgelt self-assigned this Feb 6, 2025
Copy link
Contributor

@maciekstosio maciekstosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jwajgelt jwajgelt merged commit e816172 into main Feb 10, 2025
4 checks passed
@jwajgelt jwajgelt deleted the @jwajgelt/check-eas-cli branch February 10, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants