Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add landing page #78

Merged
merged 10 commits into from
Jan 9, 2025
Merged

docs: Add landing page #78

merged 10 commits into from
Jan 9, 2025

Conversation

jakmro
Copy link
Member

@jakmro jakmro commented Jan 7, 2025

Description

Add Landing Page

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improves or adds clarity to existing documentation)

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

@jakmro jakmro marked this pull request as ready for review January 8, 2025 09:19
body: "React Native ExecuTorch allows on-device execution of AI models, eliminating the need for external API calls. This means your app's data stays on the device, ensuring maximum privacy for your users.",
},
{
title: 'cost fffective',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: 'cost fffective',
title: 'cost effective',

},
{
title: 'developer friendly',
body: "There's no need for deep AI expertise, we handle the complexities of AI models on the native site, making it simple for developers to use these models in React Native.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
body: "There's no need for deep AI expertise, we handle the complexities of AI models on the native site, making it simple for developers to use these models in React Native.",
body: "There's no need for deep AI expertise, we handle the complexities of AI models on the native side, making it simple for developers to use these models in React Native.",

Comment on lines 9 to 11
return <LogoIcon />;
}
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing is returned when this is false

@jakmro jakmro requested a review from chmjkb January 8, 2025 11:34
Comment on lines 9 to 11
ExecuTorch is a novel AI framework from the PyTorch team which provides
tools to export and run PyTorch models on edge devices like mobile
phones and microcontrollers.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use the same copy as is present on the official website, which is:
ExecuTorch is an end-to-end solution for enabling on-device inference capabilities across mobile and edge devices including wearables, embedded devices and microcontrollers. It is part of the PyTorch Edge ecosystem and enables efficient deployment of various PyTorch models (vision, speech, Generative AI, and more) to edge devices.
Possibly shorten it a little bit, maybe skip parentheses

import styles from './styles.module.css';
import useScreenSize from '@site/src/hooks/useScreenSize';

const WaveLight = () => (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those don't need to be a function, you can just do
const WaveLight =

</svg>
);

const Wave: React.FC<{ theme: string }> = ({ theme }) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a React.FC, in other parts you use simply const Wave = () => { and in others function Home. Let's pick one and stick to it (my choice would be const Wave = () =>)


function Home() {
return (
<Redirect to="/react-native-executorch/docs/fundamentals/getting-started" />
<Layout
title={`React Native ExecuTorch`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title={`React Native ExecuTorch`}
title="React Native ExecuTorch"

Comment on lines 27 to 29
href={
'https://swmansion.com/contact/projects?utm_source=react-native-executorch&utm_medium=docs'
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
href={
'https://swmansion.com/contact/projects?utm_source=react-native-executorch&utm_medium=docs'
}
href='https://swmansion.com/contact/projects?utm_source=react-native-executorch&utm_medium=docs'

@@ -7,17 +7,12 @@
text-wrap: nowrap;

color: var(--swm-off-white);
background-color: var(--swm-landing-button-purple);
background-color: var(--swm-navy-light-100);

cursor: pointer;
transition: background-color 0.3s, color 0.3s;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picky but I would slow it down a little bit, like 0.4s

@jakmro jakmro requested a review from mkopcins January 9, 2025 10:25
@jakmro jakmro merged commit 3627631 into main Jan 9, 2025
2 checks passed
@jakmro jakmro deleted the @jakmro/landing-page branch January 9, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants