-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add landing page #78
Conversation
body: "React Native ExecuTorch allows on-device execution of AI models, eliminating the need for external API calls. This means your app's data stays on the device, ensuring maximum privacy for your users.", | ||
}, | ||
{ | ||
title: 'cost fffective', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: 'cost fffective', | |
title: 'cost effective', |
}, | ||
{ | ||
title: 'developer friendly', | ||
body: "There's no need for deep AI expertise, we handle the complexities of AI models on the native site, making it simple for developers to use these models in React Native.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
body: "There's no need for deep AI expertise, we handle the complexities of AI models on the native site, making it simple for developers to use these models in React Native.", | |
body: "There's no need for deep AI expertise, we handle the complexities of AI models on the native side, making it simple for developers to use these models in React Native.", |
return <LogoIcon />; | ||
} | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing is returned when this is false
ExecuTorch is a novel AI framework from the PyTorch team which provides | ||
tools to export and run PyTorch models on edge devices like mobile | ||
phones and microcontrollers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use the same copy as is present on the official website, which is:
ExecuTorch is an end-to-end solution for enabling on-device inference capabilities across mobile and edge devices including wearables, embedded devices and microcontrollers. It is part of the PyTorch Edge ecosystem and enables efficient deployment of various PyTorch models (vision, speech, Generative AI, and more) to edge devices.
Possibly shorten it a little bit, maybe skip parentheses
import styles from './styles.module.css'; | ||
import useScreenSize from '@site/src/hooks/useScreenSize'; | ||
|
||
const WaveLight = () => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those don't need to be a function, you can just do
const WaveLight =
</svg> | ||
); | ||
|
||
const Wave: React.FC<{ theme: string }> = ({ theme }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a React.FC
, in other parts you use simply const Wave = () => {
and in others function Home
. Let's pick one and stick to it (my choice would be const Wave = () =>
)
docs/src/pages/index.tsx
Outdated
|
||
function Home() { | ||
return ( | ||
<Redirect to="/react-native-executorch/docs/fundamentals/getting-started" /> | ||
<Layout | ||
title={`React Native ExecuTorch`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title={`React Native ExecuTorch`} | |
title="React Native ExecuTorch" |
docs/src/pages/index.tsx
Outdated
href={ | ||
'https://swmansion.com/contact/projects?utm_source=react-native-executorch&utm_medium=docs' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
href={ | |
'https://swmansion.com/contact/projects?utm_source=react-native-executorch&utm_medium=docs' | |
} | |
href='https://swmansion.com/contact/projects?utm_source=react-native-executorch&utm_medium=docs' |
@@ -7,17 +7,12 @@ | |||
text-wrap: nowrap; | |||
|
|||
color: var(--swm-off-white); | |||
background-color: var(--swm-landing-button-purple); | |||
background-color: var(--swm-navy-light-100); | |||
|
|||
cursor: pointer; | |||
transition: background-color 0.3s, color 0.3s; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
picky but I would slow it down a little bit, like 0.4s
Description
Add Landing Page
Type of change
Checklist