Add feature to disable web renderer #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
reviewed
Jan 4, 2024
| @@ -57,3 +57,13 @@ rand = "0.8.5" | |||
|
|
|||
| [dev-dependencies] | |||
| reqwest = { workspace = true } | |||
|
|
|||
| [[bin]] | |||
There was a problem hiding this comment.
why this is needed? web_view is supposed to be a default feature?
Also it's reasonable thing to test how web_view example behaves without renderer feature
There was a problem hiding this comment.
Process helper needs web_renderer feature to be enabled, which is enabled by default. However, if by any chance it's disabled it gives you a nice error message about process helper needing the feature enabled.
I removed this requirement for the example now
noituri
force-pushed
the
@noituri/web-view-feature
branch
from
e2940cb to
f0e6b1b
Compare
wkozyra95
reviewed
Jan 4, 2024
jerzywilczek
approved these changes
Jan 4, 2024
noituri
force-pushed
the
@noituri/web-view-feature
branch
from
8f70464 to
c651562
Compare
noituri
force-pushed
the
@noituri/web-view-feature
branch
from
c651562 to
af4c915
Compare
wkozyra95
approved these changes
Jan 5, 2024
compositor_render/src/transformations/web_renderer/renderer_disabled.rs
Outdated
Show resolved
Hide resolved
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
web_viewfeature which is enabled by defaultI don't know if packaging on linux works though.
Closes #153