-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the vulkan video decoder to the compositor #803
Conversation
f558574
to
d8b7720
Compare
d8b7720
to
cb8e496
Compare
compositor_pipeline/src/pipeline.rs
Outdated
|
||
let limits = set_required_wgpu_limits(limits); | ||
|
||
match vk_video::VulkanCtx::new(vulkan_features, limits.clone()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an example of initiating graphics context directly in a way where users have access to e.g. adapter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just realized that I need a mac os computer to write the mac os part of the example. I'll have access to a mac next week. Do you think we can marge the example as-is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parts I understood looked good to me ✅
7d3ff8c
to
e3aba56
Compare
Co-authored-by: Wojciech Barczyński <[email protected]>
closes #751.
The decoder structure: