Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web-wasm] Make SmelterRenderer safe to use asynchronously #954

Merged
merged 1 commit into from
Feb 7, 2025
Merged

[web-wasm] Make SmelterRenderer safe to use asynchronously #954

merged 1 commit into from
Feb 7, 2025

Conversation

noituri
Copy link
Member

@noituri noituri commented Feb 7, 2025

No description provided.

@noituri noituri requested a review from wkozyra95 February 7, 2025 13:04
@noituri noituri self-assigned this Feb 7, 2025
noituri
noituri commented Feb 7, 2025
View reviewed changes
compositor_web/src/wasm/renderer.rs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved from wasm.rs

wkozyra95
wkozyra95 reviewed Feb 7, 2025
View reviewed changes
Copy link
Member

@wkozyra95 wkozyra95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test this with our vite examples, but change onCanvasCreated callback to onCanvasStarted and see if there are some issues there?

compositor_web/src/wasm/renderer.rs Outdated Show resolved Hide resolved
@noituri noituri force-pushed the @noituri/wasm-renderer-mutex branch from 20e5474 to 3208136 Compare February 7, 2025 14:22
@noituri noituri requested a review from wkozyra95 February 7, 2025 14:31
@noituri noituri merged commit f8b67ae into master Feb 7, 2025
5 checks passed
@noituri noituri deleted the @noituri/wasm-renderer-mutex branch February 7, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkozyra95 wkozyra95 wkozyra95 approved these changes

Assignees

@noituri noituri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noituri @wkozyra95