Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Ledger Signer #1386

Closed
ddoktorski opened this issue Jul 8, 2024 · 0 comments · Fixed by #1402
Closed

Support Ledger Signer #1386

ddoktorski opened this issue Jul 8, 2024 · 0 comments · Fixed by #1402
Assignees
@franciszekjob
Labels
enhancement New feature or request

Comments

@ddoktorski
Copy link
Collaborator

Feature Request

Ledger now has a Starknet App, supporting signing transactions with Stark Curve on Ledger. Any existing Starknet account can now be used with Ledger as a signer. The goal of this issue is to implement a custom LedgerSigner as an extension of the BaseSigner, which will allow signing transactions in starknet.py using a ledger device.

For reference, starknet-rs implementation:

https://github.com/xJonathanLEI/starknet-rs/blob/db1fa598232f0698d942cc974f481b5d888ac080/starknet-signers/src/ledger.rs
@ddoktorski ddoktorski added the enhancement New feature or request label Jul 8, 2024
@franciszekjob franciszekjob self-assigned this Jul 9, 2024
@franciszekjob franciszekjob mentioned this issue Jul 18, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franciszekjob franciszekjob

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Ledger signer software-mansion/starknet.py
2 participants
@ddoktorski @franciszekjob