Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Ledger signer #1402

Merged
merged 95 commits into from
Aug 7, 2024
Merged

Support Ledger signer #1402

merged 95 commits into from
Aug 7, 2024

Conversation

franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Jul 18, 2024 •
edited
Loading

Closes #1386

Introduced changes

Support signing with Ledger wallet

  • Add LedgerSigner
  • Add LedgerStarknetApp
  • Add tests for LedgerSigner

Testing, building and APDU specification of the Starknet app can be found here

  • This PR contains breaking changes

ddoktorski
ddoktorski reviewed Aug 2, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
starknet_py/net/signer/test_ledger_signer.py Outdated Show resolved Hide resolved
starknet_py/net/signer/test_ledger_signer.py Outdated Show resolved Hide resolved
starknet_py/net/signer/test_ledger_signer.py Outdated Show resolved Hide resolved
starknet_py/net/signer/test_ledger_signer.py Outdated Show resolved Hide resolved
.github/workflows/checks.yml Show resolved Hide resolved
starknet_py/net/signer/speculos_automation.json Outdated Show resolved Hide resolved
starknet_py/net/signer/ledger_signer.py Outdated Show resolved Hide resolved
starknet_py/net/signer/ledger_signer.py Outdated Show resolved Hide resolved
franciszekjob and others added 12 commits August 2, 2024 14:32
@franciszekjob franciszekjob mentioned this pull request Aug 6, 2024
Closed
ddoktorski
ddoktorski approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more comments to the docs, but overall LGTM 🔥

starknet_py/tests/unit/signer/test_ledger_signer.py Outdated Show resolved Hide resolved
starknet_py/tests/unit/signer/test_ledger_signer.py Outdated Show resolved Hide resolved
@franciszekjob franciszekjob merged commit b7ddead into development Aug 7, 2024
16 checks passed
@franciszekjob franciszekjob deleted the franciszekjob/1386-support-ledger-signer branch August 7, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

Assignees

@franciszekjob franciszekjob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Ledger Signer
3 participants
@franciszekjob @ddoktorski @kkawula