Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove skipping of certain tests #1419

Closed
kkawula opened this issue Aug 2, 2024 · 4 comments · Fixed by #1470
Closed

Remove skipping of certain tests #1419

kkawula opened this issue Aug 2, 2024 · 4 comments · Fixed by #1470
Assignees
@kkawula
Labels
invalid This doesn't seem right priority: medium tests

Comments

@kkawula
Copy link
Member

kkawula commented Aug 2, 2024 •
edited
Loading

Due to an update of devnet #547 the bug was removed which now affects our tests. Declaring multiple contracts with the same class hash isn't possible right now.
The short-term solution was to skip these tests.
kkawula added a commit to kkawula/starknet.py that referenced this issue Aug 2, 2024
@kkawula
Add # TODO (software-mansion#1419)
a2f1ddd
This was referenced Aug 2, 2024
Closed
Merged
kkawula added a commit that referenced this issue Aug 8, 2024
@kkawula
Bump devnet version to v0.2.0-rc.1 (#1422)
ee6fa1e 
* Bump devnet version to v0.2.0-rc.1

* Skip cairo 0 test

* Add # TODO (#1419)

* Bump devnet version to v0.2.0-rc.1

* Update devnet method call

* Change checks.yml

* Change on push branches

* Fix 'test_set_and_increase_time' on windows

* Update parameters for the 'abort_blocks' method in 'DevnetClient' Class
@kkawula kkawula added invalid This doesn't seem right tests priority: medium labels Aug 19, 2024
@ScottyDavies
Copy link

Hello @kkawula can i work on this?

@kkawula
Copy link
Member Author

kkawula commented Aug 26, 2024

Hi @ScottyDavies yes sure, but currently we are working on a little test refactor and this issue was intended to start after a few changes, so you can start working from development branch in a few days when we merge pr #1448 or you can start now from a branch addressed in the same pr

@ScottyDavies
Copy link

okay I will get to work

@kkawula
Copy link
Member Author

kkawula commented Aug 27, 2024

Hi, @ScottyDavies! We've added a lot of good first issue labels for newcomers. This is an opportunity to learn the codebase and they are also easier for the beginning. So I would recommend you start with them. This issue requires some context about the project so let's leave it for the future.

@kkawula kkawula mentioned this issue Aug 27, 2024
Merged
1 task
@kkawula kkawula self-assigned this Sep 5, 2024
@kkawula kkawula mentioned this issue Sep 5, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkawula kkawula

Labels
invalid This doesn't seem right priority: medium tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove skipping of certain tests software-mansion/starknet.py
2 participants
@kkawula @ScottyDavies