Replace a few cairo 0 contracts in tests vol. 2 #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guments.cairo' contracts
…s_when_calldata_not_provided
…eate_deployment_call_raw'
…ts_class_hash' fixture
kkawula
changed the base branch from
development
to
kkawula/1334-replace-cairo-0-contracts
kkawula
commented
Aug 6, 2024
1 task
starknet_py/tests/e2e/docs/guide/test_deploying_in_multicall.py
Outdated
Show resolved
Hide resolved
starknet_py/tests/e2e/docs/quickstart/test_synchronous_full_node_client.py
Show resolved
Hide resolved
Co-authored-by: Franciszek Job <[email protected]>
… kkawula/replace-cairo-0-contracts-vol2 # Conflicts: # starknet_py/tests/e2e/account/account_test.py # starknet_py/tests/e2e/contract_interaction/v1_interaction_test.py # starknet_py/tests/e2e/docs/guide/test_using_existing_contracts.py
Base automatically changed from
kkawula/1334-replace-cairo-0-contracts
to
development
August 27, 2024 10:14
…ntracts-vol2 # Conflicts: # starknet_py/tests/e2e/account/account_test.py # starknet_py/tests/e2e/contract_interaction/v1_interaction_test.py # starknet_py/tests/e2e/docs/guide/test_deploying_with_udc.py # starknet_py/tests/e2e/docs/guide/test_using_existing_contracts.py # starknet_py/tests/e2e/fixtures/contracts.py
kkawula
commented
Aug 27, 2024
kkawula
commented
Aug 27, 2024
Co-authored-by: Franciszek Job <[email protected]>
Co-authored-by: Franciszek Job <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #1334
Regarding (TODO (#1219): investigate why this test fails for v1 contract), after a talk with devnet developer, it isn't supported to declare cairo v1 contracts, that implement sending events - so this contracts were removed and certain functionality must be tested only using cairo v2 contracts.
Introduced changes