Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update starknet-devnet #1239

Merged
merged 31 commits into from
Jan 2, 2024
Merged

Update starknet-devnet #1239

merged 31 commits into from
Jan 2, 2024

Conversation

ddoktorski
Copy link
Collaborator

@ddoktorski ddoktorski commented Dec 18, 2023

Closes #1179
Related to #1219

Introduced changes

  • Use starknet-devnet-rs with RPC v0.5.1
  • Skip some failing tests / move them to integration networks
  • Slight refactoring of models (mostly related to TransactionReceipt) and some tests
  • Change logic in wait_for_tx function

Failing tests that require further investigation:

  • contract_interaction/v1_interaction_test.py fail for cairo 1 contracts compiled with compiler version 1.x. It seems to be a problem on devnet side
  • tests_on_networks/account_test.py are successful only when run one by one manually, they are moved to integration only because they fail on devnet
  • Other failing tests on network, not sure if this is related to our node or to some recent changes on integration/testnet

  • This PR contains breaking changes

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1859b5d) 97.87% compared to head (805dccc) 97.89%.

Files Patch % Lines
starknet_py/transaction_errors.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1239      +/-   ##
===============================================
+ Coverage        97.87%   97.89%   +0.01%     
===============================================
  Files               89       89              
  Lines             4236     4218      -18     
===============================================
- Hits              4146     4129      -17     
+ Misses              90       89       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddoktorski
Copy link
Collaborator Author

Windows tests checked in my fork repository -> https://github.com/ddoktorski/starknet.py/actions/runs/7246444653

@ddoktorski ddoktorski marked this pull request as ready for review December 19, 2023 09:23
Copy link
Member

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally this looks good to me

.github/workflows/checks.yml Show resolved Hide resolved
.github/workflows/checks.yml Show resolved Hide resolved
starknet_py/net/client.py Outdated Show resolved Hide resolved
docs/development.rst Show resolved Hide resolved
starknet_py/net/client.py Outdated Show resolved Hide resolved
starknet_py/net/client_models.py Outdated Show resolved Hide resolved
@ddoktorski ddoktorski requested a review from THenry14 December 27, 2023 16:08
starknet_py/net/client.py Show resolved Hide resolved
starknet_py/net/client.py Outdated Show resolved Hide resolved
starknet_py/net/client_models.py Outdated Show resolved Hide resolved
@ddoktorski ddoktorski requested a review from DelevoXDG December 29, 2023 16:27
Copy link
Contributor

@DelevoXDG DelevoXDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@ddoktorski ddoktorski merged commit 9fc34be into development Jan 2, 2024
14 of 15 checks passed
@ddoktorski ddoktorski deleted the ddoktorski/1179-devnet-rs branch March 18, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to devnet-rs
4 participants