-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update starknet-devnet
#1239
Update starknet-devnet
#1239
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## development #1239 +/- ##
===============================================
+ Coverage 97.87% 97.89% +0.01%
===============================================
Files 89 89
Lines 4236 4218 -18
===============================================
- Hits 4146 4129 -17
+ Misses 90 89 -1 ☔ View full report in Codecov by Sentry. |
Windows tests checked in my fork repository -> https://github.com/ddoktorski/starknet.py/actions/runs/7246444653 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally this looks good to me
Co-authored-by: Maksim Zdobnikau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
Closes #1179
Related to #1219
Introduced changes
starknet-devnet-rs
with RPC v0.5.1TransactionReceipt
) and some testswait_for_tx
functionFailing tests that require further investigation:
contract_interaction/v1_interaction_test.py
fail for cairo 1 contracts compiled with compiler version 1.x. It seems to be a problem on devnet sidetests_on_networks/account_test.py
are successful only when run one by one manually, they are moved to integration only because they fail on devnetOther failing tests on network, not sure if this is related to our node or to some recent changes on integration/testnet