Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor serialization code #1459

Merged
merged 16 commits into from
Sep 3, 2024
Merged

Refactor serialization code #1459

merged 16 commits into from
Sep 3, 2024

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Aug 27, 2024 •
edited
Loading

Closes #1401

Introduced changes

  • Adjusted returned and taken types in serialization correlated methods
  • Created FunctionSerializationAdapterV0 and FunctionSerializationAdapterV0 that inherits from FunctionSerializationAdapter instead older schema FunctionSerializationAdapter -> FunctionSerializationAdapterV1
  • Created base class for inheritance for DeprecatedCompiledContract and DeprecatedContractClass - _DeprecatedContract
  • Created base class for inheritance for SierraContractClass and SierraCompiledContract - _SierraContract
  • Removed pyright error overriding by warnings

  • This PR contains breaking changes

@kkawula kkawula marked this pull request as draft August 27, 2024 10:09
@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (d8fcdc6) to head (24fe95b).
Report is 1 commits behind head on development.

Additional details and impacted files 
@@               Coverage Diff                @@
##           development    #1459       +/-   ##
================================================
+ Coverage        68.39%   94.54%   +26.15%     
================================================
  Files              107      107               
  Lines             5518     5521        +3     
================================================
+ Hits              3774     5220     +1446     
+ Misses            1744      301     -1443
Files Coverage Δ
starknet_py/contract.py 96.21% <100.00%> (+44.84%) ⬆️
...serialization/data_serializers/array_serializer.py 100.00% <100.00%> (+20.00%) ⬆️
...erialization/data_serializers/output_serializer.py 100.00% <100.00%> (+40.00%) ⬆️
starknet_py/serialization/factory.py 100.00% <100.00%> (+40.27%) ⬆️
...py/serialization/function_serialization_adapter.py 100.00% <100.00%> (+46.00%) ⬆️

... and 71 files with indirect coverage changes

@kkawula kkawula marked this pull request as ready for review September 2, 2024 14:39
franciszekjob
franciszekjob approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

starknet_py/net/client_models.py Outdated Show resolved Hide resolved
starknet_py/net/client_models.py Outdated Show resolved Hide resolved
@kkawula kkawula merged commit 1abb69e into development Sep 3, 2024
16 checks passed
@kkawula kkawula deleted the kkawula/1401-refactor-serialization-code branch September 3, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciszekjob franciszekjob franciszekjob approved these changes

Assignees

@kkawula kkawula

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor serialization code
2 participants
@kkawula @franciszekjob