-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check cairo contracts formatting #1460
Check cairo contracts formatting #1460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add some kind of message why compiling failed? I suppose that it can be difficult to recognize the reason for test failure without a message. Especially when you are new to a project or external contributor
I had it on my mind, but I decided to leave it with default formatting error that |
Hmm, I suppose that it will be helpful to at least add info about start of format checking, because at first look I don't know why this compilation failed gh job. Some kind of |
Sure, message that format checking has started will be helpful, added 👍 |
…github.com/software-mansion/starknet.py into franciszekjob/1457-CI-contracts-formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #1457
Introduced changes
Check cairo contracts formatting using
scarb fmt --check