Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check cairo contracts formatting #1460

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

franciszekjob
Copy link
Collaborator

Closes #1457

Introduced changes

Check cairo contracts formatting using scarb fmt --check

  • This PR contains breaking changes

@franciszekjob franciszekjob requested a review from kkawula August 27, 2024 14:10
Copy link
Collaborator

@kkawula kkawula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add some kind of message why compiling failed? I suppose that it can be difficult to recognize the reason for test failure without a message. Especially when you are new to a project or external contributor

@franciszekjob
Copy link
Collaborator Author

Would it be possible to add some kind of message why compiling failed? I suppose that it can be difficult to recognize the reason for test failure without a message. Especially when you are new to a project or external contributor

I had it on my mind, but I decided to leave it with default formatting error that scarb displays (same when compilation fails due to any error, we don't handle it in script). Wdyt @kkawula ? Don't have a strong opinion though.

@kkawula
Copy link
Collaborator

kkawula commented Aug 28, 2024

Would it be possible to add some kind of message why compiling failed? I suppose that it can be difficult to recognize the reason for test failure without a message. Especially when you are new to a project or external contributor

I had it on my mind, but I decided to leave it with default formatting error that scarb displays (same when compilation fails due to any error, we don't handle it in script). Wdyt @kkawula ? Don't have a strong opinion though.

Hmm, I suppose that it will be helpful to at least add info about start of format checking, because at first look I don't know why this compilation failed gh job. Some kind of Checking contracts formatting message

@franciszekjob
Copy link
Collaborator Author

franciszekjob commented Aug 28, 2024

Would it be possible to add some kind of message why compiling failed? I suppose that it can be difficult to recognize the reason for test failure without a message. Especially when you are new to a project or external contributor

I had it on my mind, but I decided to leave it with default formatting error that scarb displays (same when compilation fails due to any error, we don't handle it in script). Wdyt @kkawula ? Don't have a strong opinion though.

Hmm, I suppose that it will be helpful to at least add info about start of format checking, because at first look I don't know why this compilation failed gh job. Some kind of Checking contracts formatting message

Sure, message that format checking has started will be helpful, added 👍

@franciszekjob franciszekjob requested a review from kkawula August 28, 2024 08:55
Copy link
Collaborator

@kkawula kkawula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franciszekjob franciszekjob merged commit 8e2eb52 into development Aug 28, 2024
16 checks passed
@franciszekjob franciszekjob deleted the franciszekjob/1457-CI-contracts-formatting branch August 28, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check contracts formatting
2 participants