Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure fixtures in tests #1468

Merged
merged 27 commits into from
Sep 3, 2024
Merged

Restructure fixtures in tests #1468

merged 27 commits into from
Sep 3, 2024

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Sep 3, 2024 •
edited
Loading

Relates #1219

The current version of the fixture code is cairo 1 so it isn't required to highlight it, so I removed this prefix from fixture to improve readabillity.

Introduced changes

  • Deleted cairo1 prefix from fixtures
  • Added cairo0 prefix to fixtures
  • Moved cairo1 fixture to proper file
  • Renamed tests and function names that contain cairo1 word

  • This PR contains breaking changes

kkawula added 11 commits September 3, 2024 09:46
@kkawula kkawula marked this pull request as draft September 3, 2024 08:10
@kkawula kkawula changed the title Kkawula/1219 fixture restructure Restructure fixtures in tests Sep 3, 2024
@kkawula kkawula marked this pull request as ready for review September 3, 2024 08:28
franciszekjob
franciszekjob reviewed Sep 3, 2024
View reviewed changes
starknet_py/tests/e2e/fixtures/contracts.py Outdated Show resolved Hide resolved
starknet_py/tests/e2e/fixtures/contracts_v1.py Outdated Show resolved Hide resolved
starknet_py/tests/e2e/fixtures/contracts_v1.py Outdated Show resolved Hide resolved
starknet_py/tests/e2e/fixtures/contracts_v1.py Outdated Show resolved Hide resolved
franciszekjob
franciszekjob approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@franciszekjob franciszekjob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please address nits and it's good to go.

starknet_py/tests/e2e/fixtures/contracts_v1.py Outdated Show resolved Hide resolved
starknet_py/tests/e2e/fixtures/contracts_v1.py Outdated Show resolved Hide resolved
@kkawula kkawula merged commit 1447509 into development Sep 3, 2024
16 checks passed
@kkawula kkawula deleted the kkawula/1219-fixture-restructure branch September 3, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciszekjob franciszekjob franciszekjob approved these changes

Assignees

@kkawula kkawula

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkawula @franciszekjob