Add keys (indexed fields aka topics) to the EventType (abi v2) #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-kus
force-pushed
the
imp/cairo-abi-v2-event-kind
branch
from
992b668 to
8d76ee0
Compare
franciszekjob
requested changes
Nov 22, 2024
|
Hi @m-kus, thanks for providing the PR :) left one small comment. |
Co-authored-by: Franciszek Job <[email protected]>
franciszekjob
approved these changes
Nov 24, 2024
franciszekjob
merged commit 3ffc7d8
into
software-mansion:development
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Currently ABI v2 does not preserve the event "kind" information which is necessary for decoding event payloads structured as list of keys + list of data fields.
Introduced changes
This PR adds new
keysfield to theEventTypewhich contains the list of event fields marked with#[key]in Cairo code.