Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate v1 and v2 transactions #1545

Merged
merged 78 commits into from
Jan 13, 2025
Merged

Deprecate v1 and v2 transactions #1545

merged 78 commits into from
Jan 13, 2025

Conversation

franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Jan 8, 2025 •
edited
Loading

Closes #1540

Introduced changes

Deprecate v1 and v2 transactions:

  • Remove docs examples including/mentioning these versions
  • Mark v1 and v2 methods/classes as deprecated in docs
  • Display deprecation warning when using these methods

  • This PR contains breaking changes

@franciszekjob
Remove v1 and v2 txs examples from docs
6107845
@franciszekjob
Temporarily add verbose flag when installing poetry
f305918
@franciszekjob
Fix command
40d305e
@franciszekjob
Remove poetry config installer.modern-installation false
77b053e
@franciszekjob
Use poetry check --lock instead of poetry lock --check
6d37a6b
@franciszekjob
Update pyproject.toml to remove poetry deprecation warnings
b82a63a
@franciszekjob
Temporarily add poetry --version
c72e7be
@franciszekjob
Set poetry version to 1.8.5
8ba7be9
@franciszekjob
Temporarily bring back poetry to latest version
d8cab89
@franciszekjob
Revert "Temporarily bring back poetry to latest version"
07c893c 
This reverts commit d8cab89.
@franciszekjob
Remove unnecessarily introduced CI changes
f497dc9
@franciszekjob
Remove changes in pyproject.toml
a87423a
@franciszekjob
Increase resource bounds in test_simple_declare_and_deploy
18f9cb9
@franciszekjob
Use latest poetry; Require python >= 3.9
f247f21
@franciszekjob
Run poetry lock --no-update
777db98
@franciszekjob
Remove poetry configuration of modern-installation
d57748f
@franciszekjob
Add poetry self add poetry-plugin-export in docs workflow
b4833c9
@franciszekjob
Update migration guide
76e36ea
@franciszekjob
Trigger CI
6ad0b69
@franciszekjob
Fix test_signing_fee_estimate
c382a20
@franciszekjob
Fix test_deploy_prefunded_account
7cd6dea
@franciszekjob
Update pyproject.toml and poetry.lock
19874aa
@franciszekjob
Update dependencies versions
a8aa090
@franciszekjob
Update license to TOML format
2478b8f
@franciszekjob
Update [project] and [tool.poetry]
91db366
@franciszekjob
Use [project.urls]
e80a651
@franciszekjob
Remove changes in checks.yml
826977f
@franciszekjob
Merge branch 'franciszekjob/python3.9-as-minimum-version' into franci…
c35deb6 
…szekjob/1540-txs-deprecation
ddoktorski
ddoktorski reviewed Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos in the title v2 and v3 -> v1 and v2

starknet_py/utils/deprecation.py Show resolved Hide resolved
starknet_py/utils/deprecation.py Outdated Show resolved Hide resolved
starknet_py/tests/e2e/fixtures/accounts.py Outdated Show resolved Hide resolved
@franciszekjob franciszekjob changed the title Deprecate v2 and v3 transactions Deprecate v1 and v2 transactions Jan 10, 2025
@franciszekjob
Copy link
Collaborator Author

Typos in the title v2 and v3 -> v1 and v2

Oops, right 😅

@franciszekjob franciszekjob changed the base branch from franciszekjob/python3.9-as-minimum-version to development January 10, 2025 14:27
@franciszekjob franciszekjob merged commit 2478a6c into development Jan 13, 2025
10 checks passed
@franciszekjob franciszekjob deleted the franciszekjob/1540-txs-deprecation branch January 13, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

Assignees

@franciszekjob franciszekjob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate txs versions other than v3
2 participants
@franciszekjob @ddoktorski