feat: show feature info #461
Conversation
|
@rogaldh is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
| const tableVariants = cva(["table table-sm card-table"], { | ||
| defaultVariants: { | ||
| layout: "compact" | ||
| }, | ||
| variants: { | ||
| layout: { | ||
| "compact": ["table-nowrap"], | ||
| "expanded": [] | ||
| } | ||
| } | ||
| }) | ||
|
|
||
| export interface TableCardBodyProps extends VariantProps<typeof tableVariants>, React.PropsWithChildren {} | ||
|
|
||
| export function TableCardBody({ children, ...props }: TableCardBodyProps) { |
There was a problem hiding this comment.
That code adds "variants" for the table. Original one contains table-nowrap class that adds no-wrap to all the cells.
For the feature we do not need this, as description might be quite long and with no-wrap there will be a scroll. It's not very convenient.
That's why I've added additional variant (expanded), which allows to not use no-wrap and use it for all the needed cells.
All the previous tables won't be affected
| <ReactMarkdown remarkPlugins={[remarkGFM, remarkFrontmatter]}> | ||
| {data} | ||
| </ReactMarkdown> |
There was a problem hiding this comment.
is there a way to get the text color to match the existing default text color (white)? It's a little bit hard to read with the current gray color
There was a problem hiding this comment.
There is, but it looks a bit overwhelming. Check it out:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Everything looks great. You were right about text-color: white -- too strong. I reset it to muted like you had.
I also made a modification so that the feature gate tab always shows for the feature gate. Before it would only show if the key was initialized on the current cluster. Can you just help update the feature account card so it always renders, even when the account doesn't exist?
Here is how new functionality looks like:
Variant for the feature without
simd_link: