-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMIBHID has a webserver! Closes #248 #249
SMIBHID has a webserver! Closes #248 #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is massive and looks OK, apart from some PEP8 naming convention violations.
I want to test this myself on my own SMIBHID dev board. Probably wont happen until tomorrow or Wednesday.
PEP8 issues adjusted. The webserver module is not mine, but I have adjusted enough of it already to take on and continue adjusting things like class names and have adjusted these as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the PEP8 changes
@sjefferson99 I want to test this tomorrow/Wednesday before I approve |
There is a merge conflict - please sort it :) @sjefferson99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tell my WiFi love her
No description provided.