fix: custom post types fail to apply their specific configuration on …

…registering
somoscuatro · Apr 4, 2024 · 588ef4e · 588ef4e
1 parent 0f57c89
commit 588ef4e
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 16 deletions.
diff --git a/src/custom-post-types/class-custom-post-type.php b/src/custom-post-types/class-custom-post-type.php
@@ -33,14 +33,21 @@ class Custom_Post_Type {
 	 *
 	 * @var array
 	 */
-	protected array $args = array(
-		'supports'           => array( 'title', 'editor', 'page-attributes' ),
-		'has_archive'        => true,
-		'hierarchical'       => true,
-		'public'             => true,
-		'publicly_queryable' => true,
-		'show_in_rest'       => false,
-	);
+	protected array $args = array();
+
+	/**
+	 * Class constructor.
+	 */
+	public function __construct() {
+		$this->args = array(
+			'supports'           => array( 'title', 'editor', 'page-attributes' ),
+			'has_archive'        => true,
+			'hierarchical'       => true,
+			'public'             => true,
+			'publicly_queryable' => true,
+			'show_in_rest'       => false,
+		);
+	}
 
 	/**
 	 * Registers a Custom Post Type.

diff --git a/src/custom-post-types/post-types/class-sample.php b/src/custom-post-types/post-types/class-sample.php
@@ -34,6 +34,8 @@ class Sample extends Custom_Post_Type {
 	 * Class constructor.
 	 */
 	public function __construct() {
+		parent::__construct();
+
 		$args = array(
 			// phpcs:ignore WordPress.PHP.DiscouragedPHPFunctions.obfuscation_base64_encode
 			'menu_icon'    => 'data:image/svg+xml;base64,' . base64_encode(
@@ -44,6 +46,6 @@ public function __construct() {
 			'show_in_rest' => true,
 		);
 
-		$this->args = wp_parse_args( $this->args, $args );
+		$this->args = wp_parse_args( $args, $this->args );
 	}
 }
diff --git a/src/custom-taxonomies/class-custom-taxonomy.php b/src/custom-taxonomies/class-custom-taxonomy.php
@@ -40,13 +40,20 @@ class Custom_Taxonomy {
 	 *
 	 * @var array
 	 */
-	protected array $args = array(
-		'hierarchical'      => true,
-		'show_ui'           => true,
-		'show_in_rest'      => true,
-		'show_admin_column' => true,
-		'query_var'         => true,
-	);
+	protected array $args = array();
+
+	/**
+	 * Class constructor.
+	 */
+	public function __construct() {
+		$this->args = array(
+			'hierarchical'      => true,
+			'show_ui'           => true,
+			'show_in_rest'      => true,
+			'show_admin_column' => true,
+			'query_var'         => true,
+		);
+	}
 
 	/**
 	 * Registers a custom Taxonomy.