Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevKit updates for 5.x branch #1786

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
@@ -30,7 +30,6 @@ jobs:
strategy:
matrix:
php-version:
- '8.0'
- '8.1'
- '8.2'
- '8.3'
@@ -39,30 +38,25 @@ jobs:
symfony-require: ['']
variant: [normal]
include:
- php-version: '8.0'
- php-version: '8.1'
dependencies: lowest
allowed-to-fail: false
variant: normal
- php-version: '8.3'
dependencies: highest
allowed-to-fail: false
symfony-require: 5.4.*
variant: symfony/symfony:"5.4.*"
- php-version: '8.3'
dependencies: highest
allowed-to-fail: false
symfony-require: 6.3.*
variant: symfony/symfony:"6.3.*"
symfony-require: 6.4.*
variant: symfony/symfony:"6.4.*"
- php-version: '8.3'
dependencies: highest
allowed-to-fail: false
symfony-require: 6.4.*
variant: symfony/symfony:"6.4.*"
symfony-require: 7.1.*
variant: symfony/symfony:"7.1.*"
- php-version: '8.3'
dependencies: highest
allowed-to-fail: false
symfony-require: 7.0.*
variant: symfony/symfony:"7.0.*"
symfony-require: 7.2.*
variant: symfony/symfony:"7.2.*"

steps:
- name: Checkout
2 changes: 1 addition & 1 deletion rector.php
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@
]);

$rectorConfig->sets([
LevelSetList::UP_TO_PHP_80,
LevelSetList::UP_TO_PHP_81,
PHPUnitSetList::PHPUNIT_90,
PHPUnitSetList::PHPUNIT_CODE_QUALITY,
]);

Unchanged files with check annotations Beta

{
$client = self::createClient();
$this->becomeEditor($client);

Check failure on line 47 in tests/Functional/Frontend/ExceptionsTest.php

GitHub Actions / Psalm

InvalidArgument

tests/Functional/Frontend/ExceptionsTest.php:47:29: InvalidArgument: Argument 1 of Sonata\PageBundle\Tests\Functional\Frontend\ExceptionsTest::becomeEditor expects Symfony\Component\BrowserKit\AbstractBrowser<object, object>, but Symfony\Bundle\FrameworkBundle\KernelBrowser provided (see https://psalm.dev/004)
$this->prepareData();
$client->request('GET', '/exceptions/list');
{
$client = self::createClient();
$this->becomeEditor($client);

Check failure on line 59 in tests/Functional/Frontend/ExceptionsTest.php

GitHub Actions / Psalm

InvalidArgument

tests/Functional/Frontend/ExceptionsTest.php:59:29: InvalidArgument: Argument 1 of Sonata\PageBundle\Tests\Functional\Frontend\ExceptionsTest::becomeEditor expects Symfony\Component\BrowserKit\AbstractBrowser<object, object>, but Symfony\Bundle\FrameworkBundle\KernelBrowser provided (see https://psalm.dev/004)
$this->prepareData();
$client->request('GET', '/exceptions/edit/404');
* Normally this would happen via an interactive login.
* Part of this logic is also copied from AbstractBrowser::loginUser().
*/
private function becomeEditor(AbstractBrowser $client): void

Check failure on line 100 in tests/Functional/Frontend/ExceptionsTest.php

GitHub Actions / PHPStan

Method Sonata\PageBundle\Tests\Functional\Frontend\ExceptionsTest::becomeEditor() has parameter $client with generic class Symfony\Component\BrowserKit\AbstractBrowser but does not specify its types: TRequest, TResponse
{
$sessionFactory = self::getContainer()->get('session.factory');
\assert($sessionFactory instanceof SessionFactoryInterface);
self::assertResponseStatusCodeSame(404);
$this->becomeEditor($client);

Check failure on line 51 in tests/Functional/Frontend/PageTest.php

GitHub Actions / Psalm

InvalidArgument

tests/Functional/Frontend/PageTest.php:51:29: InvalidArgument: Argument 1 of Sonata\PageBundle\Tests\Functional\Frontend\PageTest::becomeEditor expects Symfony\Component\BrowserKit\AbstractBrowser<object, object>, but Symfony\Bundle\FrameworkBundle\KernelBrowser provided (see https://psalm.dev/004)
$client->request('GET', '/custom-url');
self::assertResponseStatusCodeSame(404);
$this->becomeEditor($client);

Check failure on line 68 in tests/Functional/Frontend/PageTest.php

GitHub Actions / Psalm

InvalidArgument

tests/Functional/Frontend/PageTest.php:68:29: InvalidArgument: Argument 1 of Sonata\PageBundle\Tests\Functional\Frontend\PageTest::becomeEditor expects Symfony\Component\BrowserKit\AbstractBrowser<object, object>, but Symfony\Bundle\FrameworkBundle\KernelBrowser provided (see https://psalm.dev/004)
$client->request('GET', '/');
$client = self::createClient();
$this->preparePageTypesData($page);
$this->becomeEditor($client);

Check failure on line 86 in tests/Functional/Frontend/PageTest.php

GitHub Actions / Psalm

InvalidArgument

tests/Functional/Frontend/PageTest.php:86:29: InvalidArgument: Argument 1 of Sonata\PageBundle\Tests\Functional\Frontend\PageTest::becomeEditor expects Symfony\Component\BrowserKit\AbstractBrowser<object, object>, but Symfony\Bundle\FrameworkBundle\KernelBrowser provided (see https://psalm.dev/004)
$client->request('GET', $url);
$client = self::createClient();
$this->prepareGlobalPageData();
$this->becomeEditor($client);

Check failure on line 214 in tests/Functional/Frontend/PageTest.php

GitHub Actions / Psalm

InvalidArgument

tests/Functional/Frontend/PageTest.php:214:29: InvalidArgument: Argument 1 of Sonata\PageBundle\Tests\Functional\Frontend\PageTest::becomeEditor expects Symfony\Component\BrowserKit\AbstractBrowser<object, object>, but Symfony\Bundle\FrameworkBundle\KernelBrowser provided (see https://psalm.dev/004)
$client->request('GET', '/');
* Normally this would happen via an interactive login.
* Part of this logic is also copied from AbstractBrowser::loginUser().
*/
private function becomeEditor(AbstractBrowser $client): void

Check failure on line 369 in tests/Functional/Frontend/PageTest.php

GitHub Actions / PHPStan

Method Sonata\PageBundle\Tests\Functional\Frontend\PageTest::becomeEditor() has parameter $client with generic class Symfony\Component\BrowserKit\AbstractBrowser but does not specify its types: TRequest, TResponse
{
$sessionFactory = self::getContainer()->get('session.factory');
\assert($sessionFactory instanceof SessionFactoryInterface);