Update dash_acl.p4 Change Optional to Ternary #590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change 'optional' to 'ternary' according to last Behavioral Model meeting.
|
This work is going to take some time and it also changes the attributes of the ACL table too (ternary match will add a priority attribute, which is not in design), so it will require a larger change to get it addressed. (Why are we not using 'priority' from the beginning)? Libraries to make this work w/bmv2 will need to be updated (template updates). We may also hit some test issues as well. |
|
See comments above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change'optional' to 'ternary' according to last Behavioral Model meeting.Issue 575 Change dash_acl