Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gNOI Cold Reboot - Integrated Docker and Makefile changes #20713

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

gNOI Cold Reboot - Integrated Docker and Makefile changes #20713

wants to merge 5 commits into from

Conversation

rkavitha-hcl
Copy link

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

  1. Added code for listing out the dependant packages and the version inside the framework docker.
  2. Added the list of binaries to be started inside the frameowrk docker when it is started
  3. Added Makefiles for framework module and tests

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@vvolam
Copy link
Contributor

vvolam commented Nov 7, 2024

Bookworm compatibility Makefiles seems to be missing. could you please add them?

@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_cr_PR5 branch 6 times, most recently from 8f64ce2 to 02b4273 Compare November 21, 2024 06:26
@rkavitha-hcl rkavitha-hcl mentioned this pull request Nov 21, 2024
Open
11 tasks
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_cr_PR5 branch 2 times, most recently from e784820 to 624101c Compare November 21, 2024 12:31
@rkavitha-hcl
Copy link
Author

Bookworm compatibility Makefiles seems to be missing. could you please add them?

Added support for Bookworm

@hdwhdw hdwhdw self-requested a review November 22, 2024 16:37
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_cr_PR5 branch 3 times, most recently from 1856421 to 3887d65 Compare November 28, 2024 10:06
@rkavitha-hcl rkavitha-hcl mentioned this pull request Nov 28, 2024
Open
11 tasks
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_cr_PR5 branch 3 times, most recently from c6fddf0 to f21b38d Compare December 4, 2024 14:58
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 11, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_cr_PR5 branch 3 times, most recently from f934703 to aa12d7f Compare December 12, 2024 06:53
@rkavitha-hcl rkavitha-hcl mentioned this pull request Dec 12, 2024
Open
11 tasks
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Pull request contains merge conflicts.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Pull request contains merge conflicts.

vvolam
vvolam reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@vvolam vvolam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an estimate of CPU and memory consumption by this new container?

sonic-slave-bookworm/Dockerfile.j2
@@ -430,6 +430,8 @@ RUN apt-get update && apt-get install -y eatmydata && eatmydata apt-get install
# For audisp-tacplus
libauparse-dev \
auditd \
# For framework container build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to new sonic-slave-buster/Dockerfile.j2 file as well.

@rkavitha-hcl
Copy link
Author

Test results:

~/reboot_feature/sonic-buildimage/src/sonic-framework/tests$ ./tests
[==========] Running 41 tests from 4 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from RebootBETest
[ RUN      ] RebootBETest.WarmbootInProgressBlocksNewWarmboot
NOTICE:- Start: --- Starting rebootbackend ---
.
.
.
[       OK ] TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest.TestWarmFailureFollowedByColdBoot/1 (5103 ms)
[----------] 26 tests from TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest (63060 ms total)

[----------] Global test environment tear-down
[==========] 41 tests from 4 test suites ran. (68474 ms total)
[  PASSED  ] 41 tests.

~/reboot_feature/sonic-buildimage/src/sonic-framework/tests$ ./tests_asan 
[==========] Running 41 tests from 4 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from RebootBETest
[ RUN      ] RebootBETest.WarmbootInProgressBlocksNewWarmboot
.
.
.
[       OK ] TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest.TestWarmFailureFollowedByColdBoot/1 (5105 ms)
[----------] 26 tests from TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest (63103 ms total)

[----------] Global test environment tear-down
[==========] 41 tests from 4 test suites ran. (68527 ms total)
[  PASSED  ] 41 tests.

~/reboot_feature/sonic-buildimage/src/sonic-framework/tests$ ./tests_tsan 
[==========] Running 41 tests from 4 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from RebootBETest
[ RUN      ] RebootBETest.WarmbootInProgressBlocksNewWarmboot
NOTICE:- Start: --- Starting rebootbackend ---
.
.
.
[       OK ] TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest.TestWarmFailureFollowedByColdBoot/1 (5105 ms)
[----------] 26 tests from TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest (63119 ms total)

[----------] Global test environment tear-down
[==========] 41 tests from 4 test suites ran. (68746 ms total)
[  PASSED  ] 41 tests.

~/reboot_feature/sonic-buildimage/src/sonic-framework/tests$ ./tests_usan 
[==========] Running 41 tests from 4 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from RebootBETest
[ RUN      ] RebootBETest.WarmbootInProgressBlocksNewWarmboot
.
.
.
[       OK ] TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest.TestWarmFailureFollowedByColdBoot/1 (5103 ms)
[----------] 26 tests from TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest (63062 ms total)

[----------] Global test environment tear-down
[==========] 41 tests from 4 test suites ran. (68473 ms total)
[  PASSED  ] 41 tests.

@kishanps kishanps mentioned this pull request Jan 30, 2025
Open
@hdwhdw hdwhdw mentioned this pull request Jan 31, 2025
Draft
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvolam vvolam vvolam left review comments

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft qiluo-msft is a code owner

@xumia xumia Awaiting requested review from xumia xumia is a code owner

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

@hdwhdw hdwhdw Awaiting requested review from hdwhdw

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkavitha-hcl @vvolam @mssonicbld