Dell:Initial commit for Z9664F platform #20768
Conversation
| except ImportError as e: | ||
| raise ImportError(str(e) + "- required module not found") | ||
|
|
||
| FAN1_MAX_SPEED_OFFSET = 71 |
There was a problem hiding this comment.
FAN1_MAX_SPEED_OFFSET = 71
FAN2_MAX_SPEED_OFFSET = 73
PSU_FAN_MAX_SPEED_OFFSET = 50 . Should these values be changed for this platform ?
There was a problem hiding this comment.
It should be same for the BMC platforms.
| ver_info_fd.close() | ||
| updater.close() | ||
|
|
||
| ver_info = ver_info.get("x86_64-dellemc_z9432f_c3758-r0") |
There was a problem hiding this comment.
I have noticed it. Planning to fix this up in further commits. This will be 9664.
| self._errno = 0 | ||
|
|
||
| @staticmethod | ||
| def _get_command_result(cmdline): |
There was a problem hiding this comment.
does this require self as first argument ?
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@FuzailBrcm pls help review the pddf change |
| "num_temps":18, | ||
| "pddf_dev_types": | ||
| { | ||
| "description":"AS7726 - Below is the list of supported PDDF device types (chip names) for various components. If any component uses some other driver, we will create the client using 'echo <dev-address> <dev-type> > <path>/new_device' method", |
There was a problem hiding this comment.
Wrong platform name here.
| ############################################################################# | ||
| # DellEMC Z9664f | ||
| # | ||
| # Platform and model specific eeprom subclass, inherits from the base class, |
There was a problem hiding this comment.
Shouldn't we have copyright headers in each of these files?
There was a problem hiding this comment.
It's not been added to any of the platform files. Hence followed same convention. Please let me know if that is required.
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@geans-pin @leeprecy |
There was a problem hiding this comment.
Its always better to add a
platform/broadcom/sonic-platform-modules-dell/debian/platform-modules-z9664f.prerm
script. This will avoid some issues later. Also, helpful for testing platform .deb package installation & uninstall.
Its contents are primarily reverse steps of .postinst script.
There was a problem hiding this comment.
Added platform-modules-z9664f.prerm
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@qiluo-msft @rlhui @yxieca @prgeor -- this PR seems to have sufficient approvals. Can a repo maintainer please merge this PR? Thanks. |
Why I did it
To add support for Z9664F platform
How I did it
Implemented the support for the platform Z9664F
Switch Vendor: Dell
Switch SKU: Z9664F
ASIC Vendor: Broadcom
SONiC Image: sonic-broadcom.bin
How to verify it
Verified the platform show commands and also executed the sonic-mgmt testcases.
logs.txt
Added PDDF changes as well and attaching the logs
The syncd is not up and will be raising it to broadcom for the same as it requires SAI support.
logs.zip