Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:21473] flashrom build fix: incorrect tag name #21487

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

mssonicbld
Copy link
Collaborator

Why I did it

flashrom recently started failing to build with the below error:

Cloning into 'flashrom-0.9.7'...
/sonic/src/flashrom/flashrom-0.9.7 /sonic/src/flashrom
fatal: 'tags/0.9.7' is not a commit and a branch 'flashrom-src' cannot be created from it

Nothing in sonic-buildimage has changed in relation to this so presumably flashrom upstream renamed their tags.

Work item tracking

How I did it

This commit just fixes the formatting of the tag name to use the new format.

How to verify it

Build sonic from scratch with no cached packages.

Which release branch to backport (provide reason below if selected)

  • 202411

Tested branch (Please provide the tested image version)

master as of 20250119

Description for the changelog

flashrom build fix: incorrect tag name

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Brad House (@bradh352)

#### Why I did it

flashrom recently started failing to build with the below error:
```
Cloning into 'flashrom-0.9.7'...
/sonic/src/flashrom/flashrom-0.9.7 /sonic/src/flashrom
fatal: 'tags/0.9.7' is not a commit and a branch 'flashrom-src' cannot be created from it
```

Nothing in sonic-buildimage has changed in relation to this so presumably flashrom upstream renamed their tags.

##### Work item tracking

#### How I did it

This commit just fixes the formatting of the tag name to use the new format.

#### How to verify it

Build sonic from scratch with no cached packages.

#### Which release branch to backport (provide reason below if selected)

- [x] 202411

#### Tested branch (Please provide the tested image version)

master as of 20250119

#### Description for the changelog

flashrom build fix: incorrect tag name

#### Link to config_db schema for YANG module changes

#### A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Brad House (@bradh352)
@mssonicbld
Copy link
Collaborator Author

Original PR: #21473

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit fea54a3 into sonic-net:202405 Jan 26, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants