[YANG] Add missing entry for sonic-srv6.yang in sonic-yang-models/setup.py #21560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abdosi
reviewed
Jan 29, 2025
| }, | ||
| "SRV6_MY_LOCATORS": { | ||
| "loc1": { | ||
| "prefix": "fcbb:bbbb:1::" |
There was a problem hiding this comment.
No. The prefix length should block_len+node_len.
dgsudharsan
reviewed
Jan 30, 2025
| @@ -210,7 +210,8 @@ def run(self): | |||
| './yang-models/sonic-xcvrd-log.yang', | |||
| './yang-models/sonic-grpcclient.yang', | |||
| './yang-models/sonic-serial-console.yang', | |||
| './yang-models/sonic-smart-switch.yang',]), | |||
| './yang-models/sonic-smart-switch.yang', | |||
| './yang-models/sonic-srv6.yang']), | |||
| ('cvlyang-models', ['./cvlyang-models/sonic-acl.yang', | |||
There was a problem hiding this comment.
Do we need to define the file in cvlyang-models as well?
There was a problem hiding this comment.
What is cvlyang-models? We didn't add any yang model under cylyang-models directory
There was a problem hiding this comment.
Looks like it is related to management framework feature. In such case I don' think its required.
dgsudharsan
approved these changes
Jan 30, 2025
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abdosi
approved these changes
Jan 30, 2025
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Jan 31, 2025
…up.py (sonic-net#21560) Previously, I did not add an entry in setup.py to install the srv6 yang model Now, adding the missing entry for sonic-srv6.yang in sonic-yang-models/setup.py
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Jan 31, 2025
[Cherry-pick][YANG] Add missing entry for sonic-srv6.yang in sonic-yang-models/setup.py (sonic-net#21560)
r12f
added
Approved for msft-202412 Branch
and removed
Cherry Pick Conflict_msft-202412
labels
11 tasks
|
Cherry-pick PR to msft-202412: Azure/sonic-buildimage-msft#571 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Previously, I did not add an entry in setup.py to install the srv6 yang model
Work item tracking
How I did it
Add the missing entry for sonic-srv6.yang in sonic-yang-models/setup.py
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)