C API Exceptions #967
Merged
C API Exceptions #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
previously approved these changes
Jan 15, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
erer1243
force-pushed
the
c-api-exceptions
branch
from
b692e80 to
84acbf4
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing C API has no mechanism for passing exceptions over the FFI border. This PR changes C API functions to return a result type indicating whether an exception occurred. Previous return values now are output via pointer arguments.
Currently this just implements the changes for DBConnector, as an easier to review demo. However, the complete change is already finished locally. I can update this PR to contain the whole change when ready.
closes #932