Title: Implement Distributed Circuit Breaker #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
call-stack
changed the title
|
Thank you for your PR. The latest implementation is under |
|
@YoshiyukiMineo I have move the implementation under v2. Could you please review it? |
call-stack
changed the title
|
Hi reviewers, I've addressed the previous feedback. Would appreciate another look when you have a chance. Thanks! |
|
Thanks. I have merged your PR into |
YoshiyukiMineo
added a commit
that referenced
this pull request
Dec 28, 2024
* Title: Implement Distributed Circuit Breaker (#70) * feature/redis-circuit-breaker * feature/redis-circuit-breaker * Refactor * save state * Saving half-open state also * Saving half-open state also * Added test case * Saving state transition * Pass context * Moved redis circuit breaker to v2 * Revert go.mod and go.sum * Acked review comments * Refactor * Refactor --------- Co-authored-by: Kalpit Pant <[email protected]> * Rename * Rename * Refactor * Rename * Rename * Use generic cache store (#74) Co-authored-by: Kalpit Pant <[email protected]> * Update distributed_gobreaker.go * Update distributed_gobreaker.go * Update distributed_gobreaker.go * Update distributed_gobreaker_test.go * Update distributed_gobreaker_test.go * Update distributed_gobreaker_test.go * Update distributed_gobreaker_test.go * Update distributed_gobreaker_test.go * Update distributed_gobreaker_test.go * Update distributed_gobreaker_test.go * Update distributed_gobreaker_test.go * Update distributed_gobreaker_test.go * Update distributed_gobreaker_test.go * Update distributed_gobreaker_test.go * Update distributed_gobreaker.go * Update distributed_gobreaker_test.go * Update distributed_gobreaker_test.go * Update distributed_gobreaker_test.go --------- Co-authored-by: kp <[email protected]> Co-authored-by: Kalpit Pant <[email protected]>
|
Could you please add the tag as well? So that we can download the implementation through go modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distributed Circuit Breaker Implementation
Overview
This implementation introduces a distributed version of our circuit breaker pattern. The new
DistributedCircuitBreakerextends the existingCircuitBreakerfunctionality by supporting any storage backend through a genericCacheClientinterface, enabling distributed state management across multiple instances of an application.Key Changes
DistributedCircuitBreaker[T]struct that embeds the originalCircuitBreaker[T]CacheClientinterface that can be implemented by any storage solution (Redis, Memcached, etcd, etc.)StorageSettingsto configure the distributed circuit breakerStoredStatestruct to represent the circuit breaker state in the storage backendFeatures
Storage Flexibility
CacheClientinterfaceDesign Considerations
GetStateandSetStatemethodsTmaintains type safety for the protected operation's resultNext Steps
This enhancement makes our circuit breaker implementation more flexible and adaptable to different distributed storage requirements while maintaining its core functionality and reliability.