Scripts: fix some bugs #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| struct stat file_stat; | ||
| char p_stat[LOADERSIZE]; | ||
| for(i=0,j=0;i<p_num;i++){ |
There was a problem hiding this comment.
add new empty line between variable decleration and other code
| if (ret || !file_stat.st_size) { | ||
| printf("failed to get the file %s size !\n",(info+i)->p_name); | ||
| for (i=0, j=0; i<p_num; i++) | ||
| { |
There was a problem hiding this comment.
'{' should in the same line with for statement
| ret=stat((info+i)->p_name,&file_stat); | ||
| if (ret || !file_stat.st_size) { | ||
| printf("failed to get the file %s size !\n",(info+i)->p_name); | ||
| for (i=0, j=0; i<p_num; i++) |
There was a problem hiding this comment.
add space between '<'
| strcpy(info->p_ldr,dtb_ldr); | ||
| void get_dtb_info(struct p_info *info, char *dtb_name, uint32_t dtb_off, char* dtb_ldr) | ||
| { | ||
| strcpy(info->p_name, dtb_name); |
There was a problem hiding this comment.
use tab, not space for the indent character.
SophgoChaoWei
requested changes
Jan 14, 2025
…of x.x.x_yyyy-mm-dd and optimized coding format of "gen/pack_firmware*". Signed-off-by: Jianhang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the matching method for version info in the format of x.x.x_yyyy-mm-dd. And optimized the code format.