Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 커피챗 커리어 타입 수정 #1713

Merged
merged 2 commits into from
Dec 22, 2024
Merged

refactor: 커피챗 커리어 타입 수정 #1713

merged 2 commits into from
Dec 22, 2024

Conversation

seojisoosoo
Copy link
Member

@seojisoosoo seojisoosoo commented Dec 21, 2024 •
edited
Loading

🤫 쉿, 나한테만 말해줘요. 이슈넘버

🧐 어떤 것을 변경했어요~?

  • 커피챗 커리어의 타입을 수정했어요.

🤔 그렇다면, 어떻게 구현했어요~?

  • string[] 타입을 삭제했어요
  • 업로드 시, 배열 타입인지에 따라 string으로 가공하는 로직을 삭제했어요

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

  • 기존 커리어의 경우, 배열을 받는 칩 섹션 공통 컴포넌트를 사용했는데, 디자인 개편으로 칩 섹션이 아닌 드롭다운/바텀시트를 사용하게 되면서, 배열 타입 정의가 불필요해졌어요!

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

@height Height
Copy link

height bot commented Dec 21, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@seojisoosoo seojisoosoo self-assigned this Dec 21, 2024
@github-actions github-actions bot requested a review from hayounSong December 21, 2024 16:26
@seojisoosoo seojisoosoo requested review from simeunseo and removed request for hayounSong December 21, 2024 16:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2024 •
edited
Loading

✨✨ 스토리북으로 확인하기 ✨✨

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2024 •
edited
Loading

🚀 프리뷰 배포 확인하기 🚀

https://e49f5797.sopt-internal-dev.pages.dev

simeunseo
simeunseo approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@simeunseo simeunseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 먼저 머지해주시면 좋을것 같습니다! 🚀🚀

@seojisoosoo seojisoosoo added this pull request to the merge queue Dec 22, 2024
Merged via the queue into main with commit 9f200dc Dec 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeunseo simeunseo simeunseo approved these changes

Assignees

@seojisoosoo seojisoosoo

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: 커피챗 커리어 타입 수정
2 participants
@seojisoosoo @simeunseo