Change to use slices.Equal

sorairolake · Apr 5, 2024 · 94dd290 · 94dd290
1 parent 734cf73
commit 94dd290
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lzip_test.go b/lzip_test.go
@@ -5,6 +5,7 @@
 package lzip_test
 
 import (
+	"slices"
 	"testing"
 
 	"github.com/sorairolake/lzip-go"
@@ -29,8 +30,9 @@ func TestTrailerSize(t *testing.T) {
 func TestMagic(t *testing.T) {
 	t.Parallel()
 
-	if magic := lzip.Magic; magic != "LZIP" {
-		t.Errorf("expected magic number `%v`, got `%v`", "LZIP", magic)
+	expected := [lzip.MagicSize]byte{0x4c, 0x5a, 0x49, 0x50}
+	if !slices.Equal([]byte(lzip.Magic), expected[:]) {
+		t.Error("unexpected magic number")
 	}
 }
 

diff --git a/reader.go b/reader.go
@@ -10,7 +10,6 @@ import (
 	"errors"
 	"hash/crc32"
 	"io"
-	"reflect"
 	"slices"
 
 	"github.com/ulikunitz/xz/lzma"
@@ -33,7 +32,7 @@ func NewReader(r io.Reader) (*Reader, error) {
 		return nil, err
 	}
 
-	if !reflect.DeepEqual(header[:magicSize], []byte(magic)) {
+	if !slices.Equal(header[:magicSize], []byte(magic)) {
 		return nil, ErrInvalidMagic
 	}