Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleaner] Stop obfuscation of gz files when using --keep-binary-files #3885

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcastill
Copy link
Member

@jcastill jcastill commented Dec 16, 2024

This commit tries to honour option --keep-binary-files when using cleaner
by making sure that these files are skipped so the cleaner
doesn't attempt to apply substitutions directly on them.

Related: #3884


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

This commit tries to honour option --keep-binary-files
when using cleaner by making sure that these files
are skipped so the cleaner doesn't attempt
to apply substitutions directly on them.

Related: sosreport#3884

Signed-off-by: Jose Castillo <[email protected]>
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3885
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be using file_is_binary(), as we're explicitly saying keep binary files.

@TurboTurtle TurboTurtle added the Status/Need More Info Feedback is required to reproduce issue or to continue work label Dec 16, 2024
@jcastill
Copy link
Member Author

OK, I'll change this and push again

@suhastawade
Copy link

Hi @jcastill - Any idea when this will be merged and available in which build ?

@jcastill
Copy link
Member Author

jcastill commented Jan 2, 2025

@suhastawade I'm working on the changes requested and I hope to have a fix based on them within the next week.

@suhastawade
Copy link

@jcastill - I'm following up on the progress of this ticket. Do you need any further input from my side for additional analysis, or are we all set to proceed with merging these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status/Need More Info Feedback is required to reproduce issue or to continue work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants