Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foreman_installer] Collect correct satellite_metrics.yml #3902

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

adamruzicka
Copy link
Contributor

@adamruzicka adamruzicka commented Jan 15, 2025

Fixes ace5715


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3902
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Contributor

@pmoravec pmoravec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, the directory name changed since original agreement. /var/lib/foreman-maintain already exists, no need to have a new dir.

@arif-ali
Copy link
Member

Not knowing satellite, and a curious question, would this not affect collecting that directory from an older platform, or did that directory never exist?

Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, lgtm, just realised it was an addition recently

@arif-ali arif-ali added the Reviewed/Ready for Merge Has been reviewed, ready for merge label Jan 15, 2025
@pmoravec
Copy link
Contributor

Yeah imho the foreman_maintain directory never existed. It was planned to be used solely for the metrics, so my original PR, but then it was realized a similar existing directory already exists - so let use it.

@pmoravec pmoravec merged commit ff121f8 into sosreport:main Jan 15, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed/Ready for Merge Has been reviewed, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants