[openshift] Capture ls long listing for /mnt

[jmagrini]

This plugin is used to collect Openshift LSO details. This expands the
ceph_osd plugin since storage nodes by default are not setup for
ceph access. When gathering data from an OpenShift node when
LSO is in use, we currently do not collect the symlink data location
for LSO, which is always under /mnt. Many times this directory has
pointers/symlinks to paths instead of devices.

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• [x ] Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• [ x] Is the subject and message clear and concise?
• [ x] Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• [ x] Does the commit contain a Signed-off-by: First Lastname [email protected]?
• [ x] Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
• [ x] Are all passwords or private data gathered by this PR obfuscated?

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-3910
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[TurboTurtle]

Couple notes. I'm honestly surprised to find out we don't capture this listing already. I'm ok with the new plugin but I'm also wondering if it'd be useful to collect this by default for everyone and move it into the filesys plugin instead - thoughts @pmoravec @arif-ali ?

[TurboTurtle]

Drop this top header line, please

[TurboTurtle]

We have a standardized wrapper for dir listings so that stuff those types of collections are consistent across plugins - add_dir_listing(path).

[arif-ali]

Couple notes. I'm honestly surprised to find out we don't capture this listing already. I'm ok with the new plugin but I'm also wondering if it'd be useful to collect this by default for everyone and move it into the filesys plugin instead - thoughts @pmoravec @arif-ali ?

I'm not keen to collect this by default, it's like collecting directory listing of /. You could have users actually mounting filesystem in /mnt/<mount point>, so if we automatically collect directory of /mnt for every sos, that we'll see the listing of all files. Now, if this is a big filesystem with lots of content, that could take a very long time to collect that data too.

As an example, I already do this on my laptop, it took 13 seconds and the file would have 863198 lines.

So from my perspective is a -1 to include it by default in filesys plugin, unless there is a good case to collect this info

[arif-ali]

@jmagrini please check the pylint and flake8 tests, and resolve those 2, when you resolve the above issues that have been mentioned.

So, this plugin will run whenever there is ceph-osd on a RedHat node, even if there is no OpenShift installed it will still give you the listing for /mnt, Personally, I don't get it, but maybe I don't know Openshift enough

[pmoravec]

I forgot to do page refresh, some changes are needed. WIP on writing them..

[pmoravec]

Please merge the four commits into one.

Ensure the final commit has DCO (Signed-off-by: Jon Magrini <[email protected]> in commit message) - older 2 commits lack this hence failing DCO test.

Fix the flake8/pylint formatting issues:

sos/report/plugins/openshift_lso.py:13:1: E302 expected 2 blank lines, found 1
sos/report/plugins/openshift_lso.py:26:1: W293 blank line contains whitespace
sos/report/plugins/openshift_lso.py:28:1: W293 blank line contains whitespace
sos/report/plugins/openshift_lso.py:34:1: W293 blank line contains whitespace