Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an 'IndexError: list index out of range' in tool-info module for WitnessLint #981

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Fix an 'IndexError: list index out of range' in tool-info module for WitnessLint #981

merged 2 commits into from
Dec 9, 2023

Conversation

dbeyer
Copy link
Member

@dbeyer dbeyer commented Dec 9, 2023

No description provided.

@dbeyer dbeyer merged commit dd42180 into main Dec 9, 2023
6 checks passed
@dbeyer dbeyer deleted the fix-witnesses-lint-index-error branch December 9, 2023 20:18
@PhilippWendler
Copy link
Member

I don't think EXCEPTION is a good status for the case if len(run.output) == 0 (which btw. is equivalent to if run.output), but neither do I think that it is a good status for the existing if "witnesslint finished" not in run.output[-1]. Some generic ERROR seems to be better than mixing these cases into EXCEPTION. @marian-lingsch Can you please improve this?

@marian-lingsch
Copy link
Contributor

@marian-lingsch Can you please improve this?

Tried to do it. See #982
Feedback is very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tool support
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbeyer @PhilippWendler @marian-lingsch