-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made using dropdowns in dropped down panels work. #127
base: master
Are you sure you want to change the base?
Conversation
I've tried using this patch but it appears that you can't remove the nested dropdown by clicking outside it within the parent dropdown, you can only remove both dropdowns by clicking outside the parent dropdown. Is that the case? |
Indeed. I didn't have the time to fix this yet, though I know the cause. If you want to use the patched version, I'll push it a bit towards the top of my todo list. |
I've made a version which works for me: #131 |
Fixes soundasleep#127 (comment) by merging https://github.com/eoghanmurray 's solution (soundasleep@4db65fc).
Thanks @eoghanmurray! I've merged your solution into my fork. For the time being, I'll stick to my "minimal changes compared to 2.0.3" approach with my fork, so I didn't simply switch over to your version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering on this, position
is only called from within show
, and show
already has a reference to the current dropdown. Any idea why the jqDropdown object wasn't originally passed into position
from show
, i.e. why there was a var jqDropdown = $('.jq-dropdown:visible').eq(0)
at all?
Sorry, missed the $(window).on('resize', position);
This is a small change against the latest tagged version (2.0.3) that allows you to use jqDropdowns in panels that have been opened by jqDropdown. It makes use of what is already there (e.g. preventing the "parent" dropdown from being hidden by using the parameter of the "hide" function).
I've read that the code is no longer maintained. So I'm mainly creating this request to make other users aware of the solution. For me, jqDropdown is exactly what I was missing when implementing my jquery ui based application. Great Stuff, thanks!