release: [email protected] #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegancsmith
commented
Oct 18, 2023
| @@ -28,7 +28,7 @@ spec: | |||
| spec: | |||
| containers: | |||
| - name: embeddings | |||
| image: index.docker.io/sourcegraph/embeddings:insiders@sha256:b68cade0fdf2afcd8e78fbcb44d25bcecaec448f0c6e29fa716834cb95aa8a47 | |||
| image: index.docker.io/sourcegraph/embeddings:insiders@sha256:6bfffb3f0d15a4f71d70989656a35d617021574b9081304602e310436ce9f3f9 | |||
There was a problem hiding this comment.
for follow-up: is it write that we don't deploy a tagged version here? cc @stefanhengl
There was a problem hiding this comment.
This should definitely have a tag. Maybe we need to update the list of images?
| @@ -30,7 +30,7 @@ spec: | |||
| serviceAccountName: executor | |||
| containers: | |||
| - name: executor | |||
| image: index.docker.io/sourcegraph/executor-kubernetes:insiders@sha256:0644f1e165fe3dac6cfea1f36a14596fd52d88200385d506d2746b6d522029c3 | |||
| image: index.docker.io/sourcegraph/executor-kubernetes:insiders@sha256:83255544f6837576419008008f7a4b7c19cad1831001ba7176311930539d3d9e | |||
There was a problem hiding this comment.
for follow-up: @eseliger is it alright that we don't deploy a tagged image here?
camdencheek
approved these changes
Oct 18, 2023
|
I will follow up with tags. Indeed the actual versions used where incorrect as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is part of the Sourcegraph 5.2.1 release.
Test plan
CI checks in this repository should pass, and a manual review should confirm if the generated changes are correct.